Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented CORS middleware #131

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Implemented CORS middleware #131

merged 2 commits into from
Feb 8, 2023

Conversation

basmasking
Copy link
Member

Fixes #130

Changes proposed in this pull request:

  • Implemented the CORS middleware
  • Updated the documentation

@MaskingTechnology/jitar

@basmasking basmasking linked an issue Feb 7, 2023 that may be closed by this pull request
CORS control #130
Closed
petermasking
petermasking requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@petermasking petermasking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! We need to discuss what the best moment is for clearing the headers.

packages/jitar/src/runtime/ProcedureRunner.ts Show resolved Hide resolved
@petermasking petermasking merged commit 56164ee into main Feb 8, 2023
@petermasking petermasking deleted the 130-cors-control branch February 8, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermasking petermasking petermasking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CORS control
2 participants
@basmasking @petermasking