Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

382 add support for setting up and tearing down applications #390

Merged

Conversation

petermasking
Copy link
Member

Fixes #382

Changes proposed in this pull request:

  • Configurable sup up and tear down scripts per service
  • Better naming of module loading / importing
  • Improved contact app example (following new architecture guidelines)

@MaskingTechnology/jitar

@petermasking petermasking linked an issue Dec 5, 2023 that may be closed by this pull request

For setting up the domain, we use the following rules:

* folder per concept - we prefer using business domain concepts like 'account' or 'company';
* [function](../fundamentals/building-blocks#functions) per file - we use corresponding filenames with the function name like 'searchAccounts'' or 'createMonthReport';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two single quotes after the searchAccounts


* folder per concept - we prefer using business concepts like 'account' or 'company';
For maintainability reasons its important to get the dependencies right. We use the following rules:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word its is incorrect and should be it's or it is

documentation/docs/deploy/segmentation.md Outdated Show resolved Hide resolved
This example demonstrates how to construct and deconstruct a Jitar application.

The application creates and filles a database before the server starts.
When the application gest shut down, the database gets cleared.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: gest -> gets


**Functions**

* sayHello (`src/getData.ts`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no sayHello function in this example.

npm run standalone
```

The ``requests.http`` file contains an example requests to call the procedure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: requests -> request

npm install
```

2\. Next build the application by running the following command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Next -> Next,

examples/concepts/construction/README.md Show resolved Hide resolved
@basmasking basmasking merged commit e1f3102 into main Dec 6, 2023
7 checks passed
@basmasking basmasking deleted the 382-add-support-for-setting-up-and-tearing-down-applications branch December 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for setting up and tearing down applications
2 participants