Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

396 run middleware in application space #397

Merged
merged 6 commits into from
Dec 8, 2023
Merged

396 run middleware in application space #397

merged 6 commits into from
Dec 8, 2023

Conversation

petermasking
Copy link
Member

Fixes #396

Changes proposed in this pull request:

  • Registering middleware in the service configuration
  • Loading middleware modules from the application space
  • Request logging example in the contact app

@MaskingTechnology/jitar

@petermasking petermasking linked an issue Dec 7, 2023 that may be closed by this pull request
Run middleware in application space #396
Closed
basmasking
basmasking requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@basmasking basmasking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the existing documentation there are more references to the middleware. Not all docs files have been updated and some, for example the Environments part, still references the old way for registering the middleware.

documentation/docs/develop/middleware.md Outdated
{
"middlewares": ["./myMiddleware"]
}
}
```

It's only useful to add middleware to a node, gateway, proxy and standalone service because they are actively involved with the communication system. Adding middleware to a repository service won't result in an error, but doesn't have any effect either.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new implementation we cannot add middleware to the repository anymore. This paragraph should be removed or rewritten.

documentation/docs/fundamentals/runtime-services.md Show resolved Hide resolved
@basmasking basmasking merged commit e768b93 into main Dec 8, 2023
7 checks passed
@basmasking basmasking deleted the 396-run-middleware-in-application-space branch December 8, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basmasking basmasking basmasking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run middleware in application space
2 participants
@petermasking @basmasking