Change Encoder Steps to Float #343
Conversation
The encoderSteps and zEncoderSteps variables were changed from int to float, and the changeEncoderResolution function updated accordingly.
|
I see that changes were made to a few of the files I modified here recently and I did not merge soon enough. The CNC_Functions.h changes should now go to System.cpp. |
|
We should also remove the extraneous lines from Axis::write() as well. |
|
Also nice work @reecej, good find. I haven't had a chance to test it this solves all of it |
|
@krkeegan, are you talking about removing the steps*2, round, and /2? If so, I can include that as well. Also, if you could test at some point and see if it works, that would be very much appreciated. I don't have my Maslow kit yet so I can't validate that this fixes the error. |
|
I made PR #344 which fixes the conflict so that @BarbourSmith doesn't have to figure it out. I still need to test that this solves all of the problems, but I am pretty sure it does. Nice work! |
|
Great! I will close this pull request and wait on merging #344 until we have confirmed that it fixes the issue |
The encoderSteps and zEncoderSteps variables were changed from int to float, and the changeEncoderResolution function updated accordingly.
Full discussion at: https://forums.maslowcnc.com/t/what-is-correct-chain-pitch/1430/