Decrease the voting time to 48 hours #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 hours is too long
|
Congratulations on the pull request @BarbourSmith!! Now we need to decide as a community if we want to integrate these changes. You can vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 72 hours. Ties will not be merged. I'm just a silly robot, but I love to see people contributing so I'm going vote thumbs up! |
|
Woo!! Times up and we're ready to merge this pull request! Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
72 hours is too long. We've started using the robot in the Maslow repositories so that we can get some experience about if it is useful and one of the first things I've learned is that 72 hours is way to long to wait to merge something. 48 seems like a better amount of time. It's long enough to allow for everyone interested to weigh in, but no so long that the project is held back by waiting for PRs to merge