Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added view based scaffolding #245

Merged
merged 25 commits into from
Sep 14, 2018
Merged

added view based scaffolding #245

merged 25 commits into from
Sep 14, 2018

Conversation

josephmancuso
Copy link
Member

This PR adds better view based commands for scaffolding. No more hard to read boiler plate

@coveralls
Copy link

coveralls commented Aug 17, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 92.202% when pulling df35923 on add-view-commands into 1a416a4 on develop.

@josephmancuso josephmancuso mentioned this pull request Aug 17, 2018
Closed
@josephmancuso josephmancuso added the beta-2 Labels the issue with which beta version this issue applies to label Sep 1, 2018
@josephmancuso josephmancuso requested a review from a team September 1, 2018 18:54
@josephmancuso josephmancuso changed the base branch from master to develop September 2, 2018 20:04
@josephmancuso josephmancuso changed the base branch from develop to master September 2, 2018 20:04
@josephmancuso josephmancuso added the next major Issue scheduled for the next major release label Sep 2, 2018
@josephmancuso josephmancuso mentioned this pull request Sep 7, 2018
Closed
vaibhavmule and others added 14 commits September 8, 2018 10:54
@vaibhavmule
Remove the redundant coveralls reporting
0bbb741
@vaibhavmule
changing stage name to coverage and remove string of version number
a7475be
@josephmancuso
Merge branch 'master' into remove-reduntant-coveralls-report
0952f08
@josephmancuso
Merge branch 'master' into remove-reduntant-coveralls-report
64b86ea
@josephmancuso
Merge branch 'master' into remove-reduntant-coveralls-report
02b52a9
@josephmancuso
Merge pull request #296 from vaibhavmule/remove-reduntant-coveralls-r…
ce425f9 
…eport

Remove the redundant coveralls reporting
@vaibhavmule
move coveralls to matrix
faff420
@vaibhavmule
Merge branch 'remove-reduntant-coveralls-report' of github.com:vaibha…
413576a 
…vmule/core into remove-reduntant-coveralls-report
@vaibhavmule
run tests for coverage
5ca59f8
@vaibhavmule
refactor for python 3.6
d6d4362
@vaibhavmule
Merge branch 'master' into remove-reduntant-coveralls-report
51aa15a
@vaibhavmule
Delete Pipfile
1b476d5
@vaibhavmule
Delete Pipfile.lock
e9a244b
@josephmancuso
Merge pull request #326 from vaibhavmule/remove-reduntant-coveralls-r…
0b6a96a 
…eport

Remove redundant coveralls report
@josephmancuso josephmancuso changed the base branch from master to develop September 14, 2018 03:50
@josephmancuso josephmancuso merged commit 3456b60 into develop Sep 14, 2018
@josephmancuso josephmancuso deleted the add-view-commands branch September 19, 2018 03:00
@vaibhavmule
Copy link
Contributor

How about craft new project-name should be scaffold this way?

@josephmancuso
Copy link
Member Author

josephmancuso commented Sep 19, 2018 •
edited
Loading

umm well craft new is based in the craft repo which is sort of design to be a very very minimal CLI tool. With that being said you don't really want to have to always update it. It's more of an install once and you have it sort of thing. If we have a bug fix in the main repo and update craft to have the new bug fix ... and someone doesn't update their craft CLI tool ... Now they keep making new projects with the bug and never even know they need to update the CLI tool or what the update even does

@vaibhavmule
Copy link
Contributor

Woah, You are right.

That does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beta-2 Labels the issue with which beta version this issue applies to next major Issue scheduled for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josephmancuso @coveralls @vaibhavmule