-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove container resolving #255
Conversation
…iteFramework/core into remove-container-resolving
What was the reason to remove container resolving? |
is not particularly "removed". It is disabled by default now. You can enable it on a per application basis. The reasoning was that as there becomes more and more packages being developed, simply using a simple namespace like Some packages have the ability to override other packages by simply overriding the name in the container. |
in 2.1 and possibly 2.2, the correct way to bind things will likely be doing something like:
which binds into the container using the class name, which there should only ever be one class of the same type at a time |
Thanks for information. Make sense. |
This PR that will remove resolving via parameter and only support annotations 😢
I actually kept the possibility to resolve parameters but it's disabled by default. You can potentially enable it on a per project basis via something like this in your
wsgi.py
file:app = App(resolve_parameters=True)
but it's disabled by default and all Masonite packages and core will only use annotations