Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed requests setting double headers #470

Merged
merged 5 commits into from
Nov 10, 2018
Merged

fixed requests setting double headers #470

merged 5 commits into from
Nov 10, 2018

Conversation

josephmancuso
Copy link
Member

This PR fixes an issue that resulted in mutliple of the same header being sent

@coveralls
Copy link

coveralls commented Nov 6, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 89.973% when pulling 1e95371 on fix-double-headers into eaace78 on develop.

vaibhavmule
vaibhavmule approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@vaibhavmule vaibhavmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

The suggestion you have made about change to the dictionary is a good idea.

vaibhavmule
vaibhavmule suggested changes Nov 6, 2018
View reviewed changes
masonite/request.py Outdated Show resolved Hide resolved
vaibhavmule
vaibhavmule reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@vaibhavmule vaibhavmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in future, we can change cookies to use the dictionary.

@josephmancuso josephmancuso merged commit 1489a9d into develop Nov 10, 2018
@josephmancuso josephmancuso deleted the fix-double-headers branch November 25, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavmule vaibhavmule vaibhavmule requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josephmancuso @coveralls @vaibhavmule