fixes issue where a json null could throw an exception #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmancuso
added a commit
that referenced
this pull request
Jan 27, 2019
* added new config helper function * flake8 * added docstrings * flake8 * removed need for config prefix * Add in container (#520) * added contains method to container * formatted and added tests * bumped version * Add ability to login using multiple columns (#521) * add list to auth class * adds ability to set a password column * formatted * fixed space in exception * Adds route redirection (#545) * adds a new redirect route class * flake8 * fixes issue where a json null could throw an exception (#544) * added ability to set status code in controller (#540) * added ability to set status code in controller * flake8 * added better exception when passing incorrect parameter type (#539) * added better exception when passing incorrect parameter type * fixed view test * fix delete method when body length is 0 (#529) * fix docstring for secure headers middleware (#548) * bumped version
josephmancuso
added a commit
that referenced
this pull request
Feb 10, 2019
* added new config helper function * flake8 * added docstrings * flake8 * removed need for config prefix * Add in container (#520) * added contains method to container * formatted and added tests * bumped version * Add ability to login using multiple columns (#521) * add list to auth class * adds ability to set a password column * formatted * fixed space in exception * Adds route redirection (#545) * adds a new redirect route class * flake8 * fixes issue where a json null could throw an exception (#544) * added ability to set status code in controller (#540) * added ability to set status code in controller * flake8 * added better exception when passing incorrect parameter type (#539) * added better exception when passing incorrect parameter type * fixed view test * fix delete method when body length is 0 (#529) * fix docstring for secure headers middleware (#548) * bumped version * Adds ability to use list for route params (#552) * Adds ability to use list for route params * added new assertion * Add new data type to be done serializing after response into json. * Fixing statement else if to elif * Inicial code to test response. * Assigment the serialized data to view variable to return just at end method. * Add test to verify the return of Response. * Wrapped serialized content by json() method from Response. * Filling more code to verify why Response is come empty. * minor tweaks for tests * flake8 * added ability to specify routes in the initializer (#559) * flake8 * Add migration message (#551) * added ability to show message when migrations are unmigrated * flake8 fixes * fixed command * flake8 * Adding statement to verify whether queue's driver is default. * Adding tests do verify default queue driver. Closes #564 * reworked queue connection drivers (#563) * fixed login method (#562) * bumped version * reworked queue connection drivers * modified queues * Masonite can now retry failed jobs 3 times and call a failed callback * added queue route * added failed job handling and job database table * fixed queue command docstrings * job failed methods now need to accept payload and error * commit * can now specify the channel you want to listen on * flake8 * flake8 * removed queue failed command * fixed command option descroption * fixed failed and fair * modified test * added base queue driver * only queueable classes will get requeud on fail * flake8 * upgrades async driver * updated async * cleaned up class inheritance * flake8 * fixed contract * updated queue contract * added better test for default * bumped version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where an incoming json
nullvalue could throw an exceptionCloses #531