Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve auth #710

Merged
merged 6 commits into from
May 18, 2019
Merged

Resolve auth #710

merged 6 commits into from
May 18, 2019

Conversation

vaibhavmule
Copy link
Contributor

fixes #694

@vaibhavmule vaibhavmule changed the title Resolve auth WIP: Resolve auth May 17, 2019
@vaibhavmule vaibhavmule changed the base branch from 2.1 to develop May 17, 2019 15:55
@coveralls
Copy link

coveralls commented May 18, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 87.139% when pulling b73f881 on resolve-auth into 5d170d4 on develop.

josephmancuso
josephmancuso reviewed May 18, 2019
View reviewed changes
Copy link
Member

@josephmancuso josephmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes. You can move this from a wip to a full PR

@vaibhavmule vaibhavmule changed the title WIP: Resolve auth Resolve auth May 18, 2019
@josephmancuso josephmancuso merged commit b0c9857 into develop May 18, 2019
@josephmancuso josephmancuso deleted the resolve-auth branch August 29, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavmule @coveralls @josephmancuso