Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All drivers can switch to other drivers #73

Merged
merged 3 commits into from
Apr 25, 2018

Conversation

josephmancuso
Copy link
Member

@josephmancuso josephmancuso commented Apr 22, 2018

Closes #69

The idea here is that you should be able to quickly switch to other drivers from any driver. In other words you should be able to do something like:

def show(self, Mail):
    Mail.driver('mailgun').to(...)

even though Mail is an instance of a mail driver.

when previously you had to straight up use the MailManager class:

def show(self, Mail, MailManager):
    # send mail
    Mail.to(...)

    # switch drivers
    Mailmanager.driver('mailgun').to(...)

@josephmancuso josephmancuso self-assigned this Apr 22, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 396

  • 25 of 25 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.776%

Totals Coverage Status
Change from base Build 393: 0.2%
Covered Lines: 1188
Relevant Lines: 1385

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 22, 2018

Pull Request Test Coverage Report for Build 429

  • 25 of 25 (100.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.31%

Totals Coverage Status
Change from base Build 424: 0.2%
Covered Lines: 1237
Relevant Lines: 1450

💛 - Coveralls

@josephmancuso josephmancuso merged commit d4767af into develop Apr 25, 2018
@josephmancuso josephmancuso deleted the add-driver-method-to-drivers branch April 25, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants