Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/730 Add dev command #766

Closed
wants to merge 5 commits into from
Closed

Feature/730 Add dev command #766

wants to merge 5 commits into from

Conversation

thetonus
Copy link
Contributor

Have the ability to test, lint, and clean a repo.

References #730 and #617

masonite/commands/DevCommand.py Outdated Show resolved Hide resolved
@thetonus thetonus closed this Jun 12, 2019
@thetonus thetonus reopened this Jun 12, 2019
Copy link
Contributor

@vaibhavmule vaibhavmule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I am not wrong, isn't it implemented with makefile expect the clean part?

@thetonus
Copy link
Contributor Author

This craft command is useful for both Windows and Linux/MacOS. make is not native to Windows. Also, the find command is not the same as Linux/MacOS.

@josephmancuso
Copy link
Member

@vaibhavmule so yes and no. The way @hammacktony has built it, it will be able to be used on all masonite apps. All new 2.2 apps will have the dev command. The make file can only be used when contributing inside the core repo

@coveralls
Copy link

coveralls commented Jun 12, 2019

Coverage Status

Coverage decreased (-1.3%) to 83.958% when pulling b67e3eb on hammacktony:feature/730 into 2b18e91 on MasoniteFramework:develop.

@vaibhavmule
Copy link
Contributor

@josephmancuso if it is for masonite apps, it makes sense but the command can be simplers, as craft test, craft clean. these are a generic command, but craft lint, is based on user preference about what he wants to ignore or keep, which is dynamic?

@thetonus
Copy link
Contributor Author

For windows devs, make is not native and a bit of a hassle to install.

@vaibhavmule
Copy link
Contributor

@hammacktony Windows has Windows Subsystem for Linux, can't I use makefile with that?

@thetonus
Copy link
Contributor Author

Not all people use WSL. I have a coworker who doesn't. Percentage wise, more people use Python Windows machines than MacOS and Linux. I know? Weird. Many of them do not use WSL.

@josephmancuso josephmancuso changed the title Feature/730 Feature/730 Add dev command Jun 14, 2019
@thetonus
Copy link
Contributor Author

I am going to split this up into dev:test, dev:lint, dev:clean. Cleaner api.

@josephmancuso
Copy link
Member

hmm i think splitting it up is a bad idea. I liek the idea of being able to do multiple at once and having separate commands defeats that goal.

@thetonus
Copy link
Contributor Author

Fair enough. Didn't want to do an anti-pattern.

@josephmancuso josephmancuso added this to In progress in Minor Release Tasks Jul 26, 2019
@thetonus thetonus closed this Oct 1, 2019
Minor Release Tasks automation moved this from In progress to Done Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants