New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ServeCommand.py to use all expected host/port flags #473

Merged

josephmancuso merged 1 commit into MasoniteFramework:4.0 from StevenMHernandez:fix/472

Dec 31, 2021

Contributor

StevenMHernandez commented Dec 31, 2021

Fixes #472

Before these changes, here are the three unique errors that were occuring:

python craft serve -b 0.0.0.0 -p 12345 results in Serving on http://localhost:12321 (wrong)
python craft serve --host 0.0.0.0 -p 12345 results in Serving on http://0.0.0.0:12321 (correct)
python craft serve -b 0.0.0.0 --port 12345 results in ValueError: '--host' is not in list (wrong)
python craft serve --host 0.0.0.0 --port 12345 results in ValueError: invalid literal for int() with base 10: '0.0.0.0' (wrong)

With my changes all three errors are fixed.

python craft serve -b 0.0.0.0 -p 12345 results in Serving on http://0.0.0.0:12321 (correct)
python craft serve --host 0.0.0.0 -p 12345 results in Serving on http://0.0.0.0:12321 (correct)
python craft serve -b 0.0.0.0 --port 12345 results in Serving on http://0.0.0.0:12321 (correct)
python craft serve --host 0.0.0.0 --port 12345 results in Serving on http://0.0.0.0:12321 (correct)


          fix ServeCommand.py to use all expected host/port flags (-b, `--hos…

992eb16

…t`, `-p`, `--port`). Fixes MasoniteFramework#472

josephmancuso merged commit 2394326 into MasoniteFramework:4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment