Added feature to share individual input validation errors in session

[yubarajshrestha]

Fixes #552.

[girardinsamuel]

IMO, this would be better to do it in its own middleware to allow a user to disable sharing validation errors.

Also errors are already shared in session through errors key. I would directly use this key instead of using validation_errors key.

So maybe, we should mix both of those approach in ShareErrorsInSession middleware:

• Put sharing errors logic in this middleware
• Map errors with MessageBag as you did.

We would end up with something like this:

class ShareErrorsInSessionMiddleware(Middleware):
    def before(self, request, response):
         request.app.make("view").share(
                {
                    "errors": MessageBag(Session.pull("errors") or {}),
                }
            )
        return request

    def after(self, request, _):
        return request

[yubarajshrestha]

Created separate middleware to handle errors in frontend...

[yubarajshrestha]

Fixed requested changes.

[girardinsamuel]

I took a look again here and I would like to add a unit test.
So I added a unit test and I got an error..I need to look a bit into it, I will try to solve this soon !

[josephmancuso]

whats going on with this PR? is it good?

[girardinsamuel]

Hmm for now there is something with the unit test I wrote, I don't know if the issue is coming from tests or from the framework itself. I will push this so we can discuss it.

[yubarajshrestha]

@josephmancuso @girardinsamuel what's the status for this PR? Any issues? It's working perfectly in my case in all of my applications.

[girardinsamuel]

what's the status for this PR? Any issues? It's working perfectly in my case in all of my applications.

I was waiting for the last release to be made, to hopefully fix the unit tests I pushed to this PR.
And I will need to review it again.

[josephmancuso]

Put this forked branch up to date with 4.0

[josephmancuso]

@josephmancuso @girardinsamuel what's the status for this PR? Any issues? It's working perfectly in my case in all of my applications.

@yubarajshrestha what's preventing me from merging it really is that failing test.

[girardinsamuel]

It's a test I have added. I will remove it for now

[girardinsamuel]

That's okay for me for now.
In Masonite 5, maybe we will need to refactor session flashing and message bag validation features.