Fix setting session when middleware redirects instead of continuing request flow #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue has been observed when using a middleware which set some data in session (flash data or not) as in the example below:
Neither
key
norerrors
are correctly set into session when the redirected route loads because it does not load the session correctly because no cookies had been added to the response for those keys.It's because
Session.save()
in the upperSessionMiddleware.after()
method had never been called because of the redirect.So now, .save() is called at each session data update:
This PR fixes it.