Add Redis Session driver

[circulon]

This is an initial implementation of a driver for Redis backed sessions

@josephmancuso @girardinsamuel
Interested in your opinions on how I have implemented this

Tests are not built yet.... coming soon

[girardinsamuel]

For now the architecture looks good !

[girardinsamuel]

Hi !
Looks like linting needs to be fixed on this PR 😉

[circulon]

@girardinsamuel @josephmancuso

OK I think this is completed now.
Added tests and reworked config and general compatibility with rxisting session methods

[josephmancuso]

Looking good! I gave it a code review. Just some things I saw and some comments to make the code more similar to our other features

[girardinsamuel]

Hi @circulon, thank you again for your contribution.
One thing I missed in the first review are the type hints. We are progressively type hinting the whole Masonite codebase (It should be completed for Masonite 5). As the Cookie session driver is type hinted, could you do the same for Redis session driver ? You can check how it's done in masonite/drivers/session/CookieDriver.py. 👍

Note: i have seen it's partially done, so it should just be adding some missing type hints on some methods.

[circulon]

Hi @circulon, thank you again for your contribution. One thing I missed in the first review are the type hints. We are progressively type hinting the whole Masonite codebase (It should be completed for Masonite 5). As the Cookie session driver is type hinted, could you do the same for Redis session driver ? You can check how it's done in masonite/drivers/session/CookieDriver.py. 👍

Note: i have seen it's partially done, so it should just be adding some missing type hints on some methods.

Hi @girardinsamuel
I appreciate the thanks ;)

Yeah my project requires Redis for the cache and I use a thitf party auth system so internal lookups to validate the user token are just not feasible.
So I decided to put the user object in the session as many other frameworks do. Turns out having tokens in the user object exceeds the cookie size limit ;(

As the Redis Cache driver was already built it was just a matter of reworking that driver to fit the way Sessions work.
So there is a lot of reused code from the cache driver as you might have noticed.

Regarding Type hinting I have added most of them. There are a couple of methods like "set" that I'm not exactly sure of the return type so any pointers would be appreciated.

[girardinsamuel]

Here are missing type hints to help you.
For some return types you have to look at redis methods return type to know what is the type.

[girardinsamuel]

Final review ! Looks good to me.
@josephmancuso I guess we can merge this now.

[josephmancuso]

Final code review looks good