Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional schema indexes #76

Closed
4 tasks done
josephmancuso opened this issue Mar 11, 2020 · 11 comments
Closed
4 tasks done

Add additional schema indexes #76

josephmancuso opened this issue Mar 11, 2020 · 11 comments
Assignees
Milestone

Comments

@josephmancuso
Copy link
Member

josephmancuso commented Mar 11, 2020

need to make sure we have:

  • primary
  • index
  • unique
  • fulltext

We should have primary already

@josephmancuso
Copy link
Member Author

@corentinalcoy
Copy link
Contributor

@josephmancuso assign to me

@josephmancuso
Copy link
Member Author

I added fulltext to description

@corentinalcoy
Copy link
Contributor

corentinalcoy commented Mar 12, 2020

@josephmancuso We have an issue.
With the base code there we can not do something like that

CREATE TABLE Customer(
   LastName CHAR(30) NOT NULL,
  FirstName CHAR(30) NOT NULL,
  Email CHAR(50) NOT NULL,
  INDEX (LastName,FirstName) 
);

or

CREATE TABLE Customer(
   lastname varchar(30) not null,
  firstname varchar(30) not null,
  Email CHAR(50) not null,
  constraint email_lastname_unique UNIQUE (email, lastname) 
);

@corentinalcoy
Copy link
Contributor

I think we should fix it before continue

@josephmancuso
Copy link
Member Author

Hmm you are right. I'm gonna take another look at the schema stuff because the grammars for that are all broken down. They aren't well connected like the select query is.

Let me take a look at that tonight

@josephmancuso
Copy link
Member Author

It seems to be difficult for you and @Marlysson to build these things out so thats a foundation problem

@corentinalcoy
Copy link
Contributor

Okay
Keep in mind we can take the name of the index or constraint from like a parameter.

@josephmancuso
Copy link
Member Author

yeah let me refactor some of the schema stuff first @Marlysson

@Marlysson
Copy link
Contributor

@josephmancuso Do I keep the code intact while do you refactor this part, for while?

@josephmancuso
Copy link
Member Author

yeah just keep everything the same. I will take a look tonight

Phase 1 - Road to Documentation automation moved this from In progress to Done Mar 13, 2020
@josephmancuso josephmancuso added this to the 0.1 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants