Fixed error when was used the enum type in postgres #361
Conversation
| column, "enum", length=255, nullable=nullable | ||
| ) | ||
|
|
||
| self.table.add_constraint( |
There was a problem hiding this comment.
My only issue with this PR is adding a dedicated constraint type here. Won't things like sqlite, mssql and mysql need to specially handle this? What happens when those databases don't have check constraints?
It's past midnight right now but I'm actually confused on why some of those tests didn't fail lol ...
There was a problem hiding this comment.
I thought we were just going to add a dedicated column constraint. I did something like this in #363 to compare these 2 approaches.
There was a problem hiding this comment.
@josephmancuso by that I saw, all databases ( that we support ) had the check constraint handled equally. This change define in table level and don't column level.
But I can change to what you do in SQLite.
|
Great try at this but will fix in #363 |
Closes #359
@josephmancuso It's done and I had to change somethings.
lengthposition ( acting as length of column ) for some way, making it impossible change it ( I think that was a bug ).valuesin Constraint model to represent the values that the column will compare against.get_[constraint]_stringin platform.No break change with this changes.