-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/583 #588
Fix/583 #588
Conversation
Update community chat link to Discord
Can we get these tests fixed? looks like just 1 test is failing |
I was going to work on this issue but if you already fixed it lets just get the tests fixed and ill code review this |
Ohh I see, seems the mysql grammar for drop table is wrong 🤔 .. using it with double quotes. |
@josephmancuso It's done. |
@Marlysson i changed the code a bit. You were not hydrating the model as a way to hide the hidden fields. The problem with that approach is that if you do not hydrate the fields on the model then it will never be accessible when handling the relationships. We need them to be accessible until you serialize it. Then at that point it should be hidden from the serialization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually modified the behavior only in the collection class. The tests you wrote are still passing 👍
Awesome! |
Closes #583