Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josephmancuso @girardinsamuel
Closes #793
Closes #794
1. Config Module
Changing the way of
config_path
is loaded inload()
module.For the first load from the environment, it if is None, use the custom or default value and finally define the value back to DB_CONFIG_PATH environment ( which is first loaded in function call ).
Don't cascading the
config_path
value cause some classes already use the connection class previously loaded on top of modules.Schema: https://github.com/MasoniteFramework/orm/blob/2.0/src/masoniteorm/schema/Schema.py#L89
ConnectionFactory: https://github.com/MasoniteFramework/orm/blob/2.0/src/masoniteorm/connections/ConnectionFactory.py#L38
2. Arguments in Seed Run
Removing the second parameter in
self.option()
function, it already uses the default from the definition.