Modifying and re-uploading

[Redstone-Pro-73]

Hello, I made my own modified version of MassiveCore and Factions (both by MassiveCraft). I was wondering if I am allowed to upload them on Spigot as a premium resource. My modified version currently changes (almost) every message to a new (in my opinion) way better and cleaner version. I would probably put it on spigotmc.org for only $0.99 or $1.99. I am planning on actually adding features (not just cosmetic changes) in the future. Before I post it I'd like for you permission. Thank you :D

[markhughes]

This is a really bad idea in my opinion. There are four issues I see with this:

1. You will be in charge of future upgrades for that build of Factions and MassiveCore, you would have to take full responsibility to upgrade the plugin in the future.. and any issues reported with your plugin will have to be considered an issue with your plugin - not the original Factions and MassiveCore and again, your responsibility.
2. Your MassiveCore could (and probably will) become incompatible with other MassiveCore dependent plugins in the future. This will most likely annoy your server operators. You also can't run two versions of a plugin.
3. This is kind of morally wrong - MassiveCraft developers and volunteers have put years of time and effort into making these plugins, you are simply changing some words and adding minor features.. and then selling it?
4. Please see here for the licenses - everything you do must be in accordance to these. I believe factions is under GPL^{^#} - this comes with restrictions.

If you want to add features consider creating a seperate plugin that uses the Factions API or an alternative API.

I really don't think MassiveCraft would approve - but thats not for me to say 😁

---

^{^} https://opensource.org/licenses/GPL-3.0
^# http://choosealicense.com/licenses/gpl-3.0/

[Redstone-Pro-73]

Okay. I'll just release it for free. Is that still okay? And I'll try my
best to continue compatibility with all MassiveCraft plugins. I'll also
update it frequently. Thank you :D
On Sun, Jul 3, 2016 at 8:21 PM Mark Hughes notifications@github.com wrote:

This is a really bad idea in my opinion. There are four issues I see with
this:

1. You will be in charge of future upgrades for that build of Factions
   and MassiveCore, you would have to take full responsibility to upgrade the
   plugin in the future.. and any issues reported with your plugin will have
   to be considered an issue with your plugin - not the original Factions and
   MassiveCore (again, your responsibility)
2. Your MassiveCore could (and probably will) become incompatible
   with other MassiveCore plugins in the future. This will most likely annoy
   your server operators. You also can't run two versions of a plugin.
3. This is kind of morally wrong - MassiveCraft developers and
   volunteers have put years of time and effort into making these plugins, you
   are simply changing some words and adding minor features.. and then selling
   it?
4. Please see here
   https://github.com/MassiveCraft/Factions/tree/master/licenses for
   the licenses - everything you do must be in accordance to these. I believe
   factions is under GPL_^#_ - this comes with restrictions.

If you want to add features consider creating a seperate plugin that uses the
Factions API https://www.massivecraft.com/factions-develop or an alternative

API https://github.com/MarkehMe/FactionsFramework.

^ https://opensource.org/licenses/GPL-3.0
https://opensource.org/licenses/GPL-3.0
# http://choosealicense.com/licenses/gpl-3.0/
http://choosealicense.com/licenses/gpl-3.0/

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKJwuxAfZQN0eTls6oRxzOncR1JcwUV1ks5qSHw0gaJpZM4JD95r
.

[markhughes]

I still do think you should consider just creating external plugins (you could sell these).

[ulumulu1510]

@oloflarsson

I tagged the owner of MassiveCraft and thus holder of the intellectual Property of the two plugins you linked.

In my opinion as a contributor, releasing a modified version of MassiveCore and Factions is a bad idea.
Not only will people come to you with problems that lie in our version of MassiveCore, but also some of your customers/users will come to us. It would create a havoc over responsibility and I am quite sure you underestimate that.

Also, if I am thinking myself in your position right now, do you know how much work it will be to stay up to date with our changes? How many times you will have to fetch the changes in git an panestackingly amend them into "your" version of it? I know what I am talking about, because that is what we contributors do every time we work on it. But I am not sure you are aware that this will be demanded by any potentail future users of your version, as they would surely want it to be compatible with all of our other plugins.

I second the morality and license points Markehme brought up.

If you want to do something for the community, why not make a PR where you/they are able to change things such as these messages and colors? Wouldn't that benefit the community more?

[Redstone-Pro-73]

Okay. Thank you all for your responses. I might actually consider creating
that pull request :D Thank you all for your time and have now reconsidered
my discision. I won't make my custom version public. Thank you again for
all of your (quick) responses.
On Sun, Jul 3, 2016 at 9:28 PM Benjamin notifications@github.com wrote:

@Cayorion

I tagged the owner of MassiveCraft and thus holder of the intellectual
Property of the two plugins you linked.

In my opinion as a contributor, releasing a modified version of
MassiveCore and Factions is a bad idea.
Not only will people come to you with problems that lie in our version of
MassiveCore, but also some of your customers/users will come to us. It
would create a havoc over responsibility and I am quite sure you
underestimate that.

Also, if I am thinking myself in your position right now, do you know how
much work it will be to stay up to date with our changes? How many times
you will have to fetch the changes in git an panestackingly amend them into
"your" version of it? I know what I am talking about, because that is what
we contributors do every time we work on it. But I am not sure you are
aware that this will be demanded by any potentail future users of your
version, as they would surely want it to be compatible with all of our
other plugins.

I second the morality and license points Markehme brought up.

If you want to do something for the community, why not make a PR where
you/they are able to change things such as these messages and colors?
Wouldn't that benefit the community more?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKJwuyDVuAnbgcLs_9PQMAWdgqZ1_0iqks5qSIvPgaJpZM4JD95r
.

[Redstone-Pro-73]

Also, I don't think the API has enough functionality to actually add the features I think people would want. Yet again I'd have to go check the API. I'm currently away from my PC and am only on my phone at the moment. I'll check it some time within two days.

[markhughes]

There is always room for improvement with the API too - please let us know what you're after! 😁

[Redstone-Pro-73]

If you want more information about my custom build is, and my ideas on how
I can implement it via a pull request, is there some type of PM we can talk
through? You can even come on my network too see my current custom build.
Which maybe I can turn into an external plugin or even get it in a pull
request.
On Sun, Jul 3, 2016 at 10:10 PM Mark Hughes notifications@github.com
wrote:

There is always room for improvement with the API too - please let us know
what you're after! 😁

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKJwu3F14d7btwx1EhBs4TDbqtUiq5NCks5qSJXMgaJpZM4JD95r
.

[markhughes]

I'm really curious! 😄

Can you add me on skype - markehme - and we can have a chat about your ideas?

[Redstone-Pro-73]

Sure. I can't just yet. It's the forth today and will be away from my PC,
but surely tomorrow! 😀
On Sun, Jul 3, 2016 at 10:47 PM Mark Hughes notifications@github.com
wrote:

I'm really curious! 😄

Can you add me on skype - markehme - and we can have a chat about your
ideas?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AKJwu8TjmHGA_iWMlrtcp5l5WVuqbnFpks5qSJ5fgaJpZM4JD95r
.

[Redstone-Pro-73]

Do you have discord? I don't have skype, sorry. You can add me on discord with this email: redstonepro73@gmail.com

[Redstone-Pro-73]

Whoops... didn't mean to close the issue :I I just got skype and will add you. If you do please still add me on discord since that is where I will respond the fastest.