Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Megamix 1 #21

Merged
merged 22 commits into from
Jun 2, 2020
Merged

Refactor Megamix 1 #21

merged 22 commits into from
Jun 2, 2020

Conversation

MasterKale
Copy link
Owner

This is a pretty extensive PR intended to make it easier to pass info from browser to server by exposing more of the data structures returned from the browser start methods to the complimentary verification methods in server. This should make it easier to track what values are being returned from these calls and enhance them with future return values as the spec evolves. It should also make it easier to test these libraries for conformance with the spec.

For more context on the original intent of this PR, see #20.

There was also some mixed use of "base64" encoding when, according to the spec, "base64url" encoding is required. This was due to me, in my naivety, conflating the two. It should now be easier to tell when these encoded values are being used versus the ArrayBuffers they represent.

For more detailed information on the changes in this PR, see below:

  • [browser] (BREAKING) Refactor startAttestation() and startAssertion() to return more of the output from the navigator.credentials calls
  • [browser] Replace base64-js dependency with internal functionality
  • [browser, server] Standardize on use of Base64URL encoding when converting to and from JSON
  • [server] (BREAKING) Remove references to "base64" from generateAttestationOptions() and generateAssertionOptions() by renaming the excludedBase64CredentialIDs and allowedBase64CredentialIDs to excludedCredentialIDs and allowedCredentialIDs respectively
  • [typescript-types] (BREAKING) Migrate some non-shared typings into server

@MasterKale MasterKale merged commit ed960d8 into master Jun 2, 2020
@MasterKale MasterKale deleted the feature/improve-browser branch June 2, 2020 22:50
@MasterKale
Copy link
Owner Author

These changes have been released as v0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants