-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Megamix 1 #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that properties on PublicKeyCredentials are non-enumerable getters, so the spread operator won’t pick them up. This means we need to manually re-construct attestation and assertion credentials when we convert them to JSON.
These changes have been released as v0.5.0 |
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty extensive PR intended to make it easier to pass info from browser to server by exposing more of the data structures returned from the browser start methods to the complimentary verification methods in server. This should make it easier to track what values are being returned from these calls and enhance them with future return values as the spec evolves. It should also make it easier to test these libraries for conformance with the spec.
For more context on the original intent of this PR, see #20.
There was also some mixed use of "base64" encoding when, according to the spec, "base64url" encoding is required. This was due to me, in my naivety, conflating the two. It should now be easier to tell when these encoded values are being used versus the ArrayBuffers they represent.
For more detailed information on the changes in this PR, see below:
startAttestation()
andstartAssertion()
to return more of the output from thenavigator.credentials
callsbase64-js
dependency with internal functionalitygenerateAttestationOptions()
andgenerateAssertionOptions()
by renaming theexcludedBase64CredentialIDs
andallowedBase64CredentialIDs
toexcludedCredentialIDs
andallowedCredentialIDs
respectively