Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Megamix 1 #21

Merged
merged 22 commits into from
Jun 2, 2020
Merged

Refactor Megamix 1 #21

merged 22 commits into from
Jun 2, 2020

Commits on Jun 1, 2020

  1. Update types to reflect original response shape

    @MasterKale
    MasterKale committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2e31764 View commit details
    Browse the repository at this point in the history

  2. Refactor browser methods to return near-raw resp.

    @MasterKale
    MasterKale committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    db28323 View commit details
    Browse the repository at this point in the history

  3. Try to communicate the expected string encoding

    @MasterKale
    MasterKale committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    16e2e87 View commit details
    Browse the repository at this point in the history

  4. Move some type comments around

    @MasterKale
    MasterKale committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    16b9d33 View commit details
    Browse the repository at this point in the history

  5. Stop exporting two now-internal types

    @MasterKale
    MasterKale committed Jun 1, 2020
    3 Configuration menu
    Copy the full SHA
    9776fc1 View commit details
    Browse the repository at this point in the history

  6. Refactor verify methods to new response structure

    @MasterKale
    MasterKale committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    c3d641b View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2020

  1. Move some enums and types out of types package

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    344ba5c View commit details
    Browse the repository at this point in the history

  2. Update AuthenticatorDevice type def

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    063282c View commit details
    Browse the repository at this point in the history

  3. Add new Base64URL<->Buffer helper methods

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    cac8181 View commit details
    Browse the repository at this point in the history

  4. Refactor to incorporate new helper

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    451ae55 View commit details
    Browse the repository at this point in the history

  5. Update start methods to use new helper

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5ae8249 View commit details
    Browse the repository at this point in the history

  6. Mark base64-js as a dev dependency

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    7cc6757 View commit details
    Browse the repository at this point in the history

  7. Get unit tests passing again

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    ae19fbd View commit details
    Browse the repository at this point in the history

  8. Explicitly define id and type 

    It turns out that properties on PublicKeyCredentials are non-enumerable getters, so the spread operator won’t pick them up. This means we need to manually re-construct attestation and assertion credentials when we convert them to JSON.
    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    047413a View commit details
    Browse the repository at this point in the history

  9. Exclude methods from credential JSON output

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    870e83e View commit details
    Browse the repository at this point in the history

  10. Remove some old comments

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    555e694 View commit details
    Browse the repository at this point in the history

  11. Remove base64-js from dev dependencies

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    9bc83eb View commit details
    Browse the repository at this point in the history

  12. Fix verifyAssertionResponse tests

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3f7fd9f View commit details
    Browse the repository at this point in the history

  13. Rename “Base64String” to “Base64URLString”

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    1bb9d9f View commit details
    Browse the repository at this point in the history

  14. Uninstall base64-js types

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    2ed2974 View commit details
    Browse the repository at this point in the history

  15. Standardize on use of “base64url” where applicable

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    e82c9e9 View commit details
    Browse the repository at this point in the history

  16. Remove “base64” references from options generators

    @MasterKale
    MasterKale committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    bb5e3e9 View commit details
    Browse the repository at this point in the history