Fix encryption and decryption #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karen-avetisyan-mc
requested changes
Jan 31, 2024
encryption/encryption.go
Outdated
| @@ -28,23 +32,48 @@ func encryptPayloadPath(jsonPayload *gabs.Container, jsonPathIn string, jsonPath | |||
| Kid: config.GetEncryptionKeyFingerprint(), | |||
| Cty: "application/json", | |||
| } | |||
|
|
|||
| payload, err := jwe.Encrypt(config, jsonPayload.String(), joseHeader) | |||
| var payloadPath *gabs.Container | |||
There was a problem hiding this comment.
please provide an initialisation to this variable
encryption/encryption.go
Outdated
| @@ -28,23 +32,48 @@ func encryptPayloadPath(jsonPayload *gabs.Container, jsonPathIn string, jsonPath | |||
| Kid: config.GetEncryptionKeyFingerprint(), | |||
| Cty: "application/json", | |||
| } | |||
|
|
|||
| payload, err := jwe.Encrypt(config, jsonPayload.String(), joseHeader) | |||
| var payloadPath *gabs.Container | |||
There was a problem hiding this comment.
is this variable used in this code?
encryption/encryption.go
Outdated
| return jsonPayload | ||
| } | ||
|
|
||
| func decryptPayloadPath(jsonPayload *gabs.Container, jsonPathIn string, jsonPathOut string, config jwe.JWEConfig) *gabs.Container { | ||
| inJsonObject := jsonPayload.Path(jsonPathIn).Data().(string) | ||
| var inJsonObject string |
There was a problem hiding this comment.
please movie lines 66-76 to a separate function.
encryption/encryption.go
Outdated
| @@ -57,9 +86,17 @@ func decryptPayloadPath(jsonPayload *gabs.Container, jsonPathIn string, jsonPath | |||
| if jsonPathOut == "$" { | |||
| jsonPayload = jsonDecryptedPayload | |||
| } else { | |||
| jsonPayload.DeleteP(jsonPathIn) | |||
| jsonPayload.Set(jsonDecryptedPayload, jsonPathOut) | |||
| if jsonPathOut[0] == '$' { | |||
There was a problem hiding this comment.
this If statement is duplicate, please consider to implement a helper function for it
karen-avetisyan-mc
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle payload path parameters and add tests cases