This repository has been archived by the owner on Feb 28, 2024. It is now read-only.
#9 Add PHP 8.0 support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PHP 8.0 to the build matrix Enable composer caching Change dependencies for PHP 8 Remove composer.lock file Use Yoast PhpUnitPolyfill base test case in PsrStreamInterfaceImplTest Fix boolean encoding Fix exception handling in PHP 8
|
Hey @danny-gallagher, could you review this? Also please rerun the build, it did succeed in my fork: https://github.com/kick-the-bucket/client-encryption-php/actions/runs/1055116434 - this is an issue with permissions in github, when creating MRs from forks... |
Thanks for the PR, It's in our queue :) |
jaaufauvre
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
@kick-the-bucket, all good! Thanks very much for the PR (and having maintained the backward compatibility)
| php-version: ${{ matrix.php }} | ||
| coverage: none | ||
|
|
||
| - name: Cache Composer dependencies |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
masterbranchLink to issue/feature request
#9
Description
Since PHP 8.0 a lot of function throw
TypeErrors instead of returningfalsewhen they receive bad parametersTypeErrordoes not extendException, both of those implementThrowableinterface, which is not present in PHP 5.6, only since 7.0