Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build issue due to pyOpenSSL #24

Closed
wants to merge 4 commits into from

Conversation

ShimonaR-MC
Copy link
Contributor

PR checklist

  • An issue/feature request has been created for this PR
  • Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • File the PR against the master branch
  • The code in this PR is covered by unit tests

Link to issue/feature request: add the link here

Description

Fix for the build issue:
AttributeError: module 'OpenSSL.crypto' has no attribute 'load_pkcs12'

The latest version of pyOpenSSL - version 23.3.0 (2023-10-25) has removed support for OpenSSL.crypto.load_pkcs12, which is causing this build issue.
As a quick fix, restricting pyOpenSSL version to the previous version 23.2.0 for which this oauth signer library works.

Refer: 23.3.0 (2023-10-25) https://pypi.org/project/pyOpenSSL/
https://github.com/pyca/pyopenssl/pull/1223/files

Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ShimonaR-MC
Copy link
Contributor Author

Sonar build runs off the main branch and fails due to test failure with the issue "AttributeError: module 'OpenSSL.crypto' has no attribute 'load_pkcs12'". Hence updated the main branch directly with the version change. Closing this PR.

@ShimonaR-MC ShimonaR-MC closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants