Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No point in the tab bar if there's only one tab with content #464

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

therealryan
Copy link
Collaborator

@therealryan therealryan commented Jul 14, 2023

Mostly resolves #328, but we were stopped from hiding the tab bar altogether by some weirdness that I don't have the soul energy to dive into. This is ok-ish though, as the tab bar shows overall test result so we can justify keeping it even when there's only one tab

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@therealryan therealryan added enhancement New feature or request javascript Pull requests that update Javascript code labels Jul 14, 2023
@therealryan therealryan merged commit baf651f into main Jul 14, 2023
10 checks passed
@therealryan therealryan deleted the tab_display branch July 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide report detail tabs if possible
1 participant