Read latest request body instead of snapshot copy #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@bhargavmodi or @danny-gallagher would you have any feedback on this PR please? |
karen-avetisyan-mc
requested review from
danny-gallagher and
karen-avetisyan-mc
danny-gallagher
added
the
safe
karen-avetisyan-mc
approved these changes
Sep 20, 2023
karen-avetisyan-mc
requested changes
Sep 20, 2023
| @@ -3,7 +3,7 @@ package oauth | |||
| import ( | |||
| "crypto/rsa" | |||
| "errors" | |||
| "io/ioutil" | |||
| "io" | |||
There was a problem hiding this comment.
Although the changes looks good, the library build fails to import the io module. this version 1.12 still assumes io/util is not deprecated
There was a problem hiding this comment.
we will merge those changes directly
There was a problem hiding this comment.
We will incorporate these changes as part of this PR: #8
|
Addressed in: #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #7
When reading the request body to be signed, the actual body could have been modified since when it was first created (for example when using an encryption middleware).
Instead of using
req.GetBody()(which returns a snapshot copy, see https://github.com/golang/go/blob/master/src/net/http/request.go#L919), we should read the actual latest content of the body.In addition, I have swapped the deprecated
ioutilpackage forioPR checklist
masterbranch