Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A wrong signature base string is generated when the provided URI contains non-encoded characters #12

Closed
jaaufauvre opened this issue Apr 26, 2019 · 0 comments
Closed

A wrong signature base string is generated when the provided URI contains non-encoded characters #12

jaaufauvre opened this issue Apr 26, 2019 · 0 comments
Assignees
@jaaufauvre
Labels
bug Something isn't working

Comments

@jaaufauvre
Copy link
Member

jaaufauvre commented Apr 26, 2019 •
edited

Working example (request is accepted)

GET /?param=token1%3Atoken2 HTTP/1.1
Host: example.com
  • URI: URI.create("https://example.com/?param=token1%3Atoken2")
  • Base string: GET&https%3A%2F%2Fexample.com&param%3Dtoken1%253Atoken2

Issue reproduction (request is rejected)

GET /?param=token1:token2 HTTP/1.1
Host: example.com
  • URI: URI.create("https://example.com/?param=token1:token2")
  • Actual base string: GET&https%3A%2F%2Fexample.com&param%3Dtoken1%253Atoken2
  • Expected base string: GET&https%3A%2F%2Fexample.com&param%3Dtoken1%3Atoken2
@jaaufauvre jaaufauvre self-assigned this Apr 26, 2019
@jaaufauvre jaaufauvre mentioned this issue Apr 26, 2019
Merged
jaaufauvre added a commit that referenced this issue Apr 26, 2019
@jaaufauvre
Merge pull request #13 from jaaufauvre/master
507ec44 
Fixed #12
@jaaufauvre jaaufauvre changed the title A wrong signature base string is generated when the provided URI contains non encoded characters A wrong signature base string is generated when the provided URI contains non-encoded characters Apr 26, 2019
@jaaufauvre jaaufauvre added the bug Something isn't working label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaaufauvre jaaufauvre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaaufauvre