Fix buffer usage due to security issues #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaaufauvre
added
the
safe
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
masterbranchLink to issue/feature request: add the link here
Description
Although I don't have exact payload to show the security impact. But since this param may come from user and not all necessary validations can be performed. I believe that we should fix usage of Buffer. Here, nodejs/node#19079 we can find bit more detailed context on why this PR is raised.
I ran tests and after bit of setting up environment struggle, I managed to pass tests that ran. However, it would be a good idea if someone from dev team can run the tests and check if everything passes.