-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPM spec file and version management to Makefile. #539
base: master
Are you sure you want to change the base?
Conversation
@jollyroger thanks for investing in RPM. Why do you think the RPM build should be part of the main glide repo? I ask because setup to create debian package is in a separate repo. If you can provide more insight it would be helpful. |
@mattfarina , I know that Debian does not prefer to use upstream-provided As for the RPM-based distros there is no such policy afaik. But since it's just a single file it's nice to have it somewhere nearby (haven't seen any packages of glide around except the Debian ones). Especially if it's so easy to build a new version with a single command. When I needed an RPM and found none I just did packaging myself, additional changes resulted in the patch I provided earlier. Apart from the
So if your concern is for spec-file only and the rest seems ok to you, I can split my patch into two. |
Friendly bump. |
@jollyroger I'll look at this shortly. I need to get back up to speed on RPMs before making a decision. This needs to be forward compatible since as we continue working (it may already be and I'm just not aware). |
@mattfarina thanks, I'll wait for your answer. Didn't understand your concern though. Could you please put in more details? I'll gladly answer whether this solution already fits your requirements or not. |
For what it's worth I maintain an AlpineLinux package for glide that's been accepted upstream. |
Friendly bump. |
This commit allows user to build an RPM package with a single command just using source tarball. To achieve this i've added an sdist target to the Makefile. This target will generate source tarball and put VERSION file inside to allow make utility to detect version of the source tarball even if no git is present. If used a tarball generated by sdist target it is possible to build RPMs with a single command: rpmbuild --define "_glide_version 0.11.1-11-gb5ebdcb" -ta \ dist/glide-0.11.1-11-gb5ebdcb-src.tar.gz
This commit allows user to build an RPM package with a single command just
using source tarball. To achieve this i've added an sdist target to the
Makefile. This target will generate source tarball and put VERSION file inside
to allow make utility to detect version of the source tarball even if no git is
present.
If used a tarball generated by sdist target it is possible to build RPMs with a
single command: