Tests PSR compatible #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'm good with the move to PSR-4. Punting to @mattfarina to weigh in on this. |
|
@mattfarina what do you think about this? |
| use HTML5\Parser\StringInputStream; | ||
| use HTML5\Parser\Scanner; | ||
| use HTML5\Parser\Tokenizer; | ||
| require 'EventStack.php';class TokenizerTest extends \HTML5\Tests\TestCase { |
There was a problem hiding this comment.
The require and class definition should be on different lines.
|
The change to a PSR-4 autoloader for the tests makes sense. Let's clean up the couple issues and we can merge this in. |
This was referenced May 14, 2014
Merged
|
Changes Unknown when pulling 30aa8a6 on goetas:prs-tests into * on Masterminds:master*. |
mattfarina
added a commit
that referenced
this pull request
May 15, 2014
Fixes the testing errors and makes the tests PSR compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have adapted the test suite to be PSR compatible