Fixed alphabet, ß now can be detected #73
Conversation
The english alphabet does not allow the substitution of a lowercase z in place of another uppercase A.
|
hi! can you create a test case for this? I'm still not able to understand the PR.... :-( |
|
Okay, what's the best way to attach a test case? Stick it in here, or close this and start again? |
|
Anyway, I'm at work at the moment so I'll have to make a test case later. Anyway, what the issue was is that before, the ALPHA constants were like this: abcdefAghijklmnopqrstuvwxy Now, you'll notice that there is a stray 'A' in there, and the 'z' is missing. Therefore, ß would be detected as &s, and z would cause another error because ; was expected. Changing it to: abcdefghijklmnopqrstuvwxyz ...fixes the issue. Hopefully that should explain it enough for you. :) |
|
You can add a second commit, pushing again this branch. You can add a test here |
|
Yeah, I don't think this really worth a test case. Plus, what would it be testing? A class constant? |
|
@technosophos Do you know why we have this "A" in this constant "abcdefAghijklmnopqrstuvwxyABCDEFGHIJKLMNOPQRSTUVWXYZ01234567890" ? It is a part of a very old commit. May be just a typo? |
|
@Westie I will investigate on that, but most probably it is just a typo.... |
|
The extra |
|
Good! |
Fixed a typo on HTML5 Scanner class
|
This error would still exist on the 1.x branch. Do we know if people are still using that branch? Maybe cherry-pick this bug fix over there and release a bugfix release. Any thoughts? |
|
@mattfarina Unfortunately https://github.com/composer/packagist does not provide the number of downloads for each version (or some kind of aggregate grouped value per major release). / cc @Seldaek But a 1.x bugfix release can be useful... |
|
Released 1.0.6 with this fix in it. |
|
👍 |
The english alphabet does not allow the substitution of a lowercase z in place of another uppercase A.