-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust error responses #24
Conversation
|
||
var ( | ||
// ErrWrongVCS is returned when an action is tried on the wrong VCS. | ||
ErrWrongVCS = errors.New("Wrong VCS detected") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not immediately obvious to me where this would be used. I don't remember all the flows exactly, but isn't this the kind of thing where you'd only encounter this if you try to explicitly use the wrong type on an existing on-disk repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErrWrongVCS
is an error that exists today. It happens when the type of VCS you already have cloned locally is mismatched with the remote location type. Say the local VCS is bzr and the endpoint is git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, this did show up in Glide when folks migrated from Google Code (Hg) to GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, totally me just boneheadedly note scrolling far enough down in the diff to see these already existed
- Error types depend if the action is local or remote - Same error messages from differing VCS - Underlying error and output are available
@technosophos and @sdboyer I made some major changes from the first commit.
If there's any feedback please let me know. |
This is a work in progress
@technosophos @sdboyer any feedback?