fix: the tap helper should not enforce any return type for the callback

MatanYadaev · Nov 15, 2021 · 19098c7 · 19098c7
1 parent 53ef50c
commit 19098c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 
+### Fixed
+* No return type should be enforced for closure of tap helper 
+
 ### Changed
 * Improved return type for Collection::first, last, get, pull when giving a  default value.
 

diff --git a/stubs/Helpers.stub b/stubs/Helpers.stub
@@ -30,7 +30,7 @@ function retry($times, callable $callback, $sleep = 0, $when = null)
 /**
  * @template TValue
  * @param TValue $value
- * @param null|callable(TValue): void $callback
+ * @param null|callable(TValue): mixed $callback
  * @return mixed
  */
 function tap($value, $callback = null)