ListBoxAssist.IsToggle - Ensure last clicked item is always selected #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works, and I get that in most cases we probably expect the radio button group style behavior, but I am wondering if a better fix. But I am thinking there are cases where "none" would be valid. I am thinking we might want to allow that case to still exist but have this be the default. |
If you read the issue, you will see I had the same concern. So do we need an AP to allow the none case then? EDIT: I have added the AP and updated the PR. |
Default behavior is now changed so the selected item can not be deselected. Setting this new AP will allow it, basically falling back to the old default behavior.
nicolaihenriksen
added
demo app
Keboo
approved these changes
Oct 29, 2023
|
Yea something like that looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3235
As the last comment in the issue states, when explicitly applying
ListBoxAssist.IsToggle=true, the expected behavior is most likely that the items should behave similar to a radio button group. This ensures that the user cannot do anything to end up in a situation where no elements are selected. However, there are still no guards around selection being "removed" from code.To fix the latter part, we could attach a
PropertyChangedCallbackon theIsToggleDP, but we would probably also need to listen for changes in theListBox.Itemscollection which I think is probably taking it a step too far. If the developer explicitly setsListBoxAssist.IsToggle=true, let's assume that he/she also knows not to do anything weird.