Add webhook destniation #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuck-alt-delete
approved these changes
Sep 13, 2023
src/webhookDataGenerator.ts
Outdated
| }); | ||
|
|
||
| } catch (error) { | ||
| console.error('Error sending data to webhook:', error); |
There was a problem hiding this comment.
Should we include some retry behavior in the case that we’ve hit the rate limit (status 429)? Doc
There was a problem hiding this comment.
Thank you for the great suggestions @chuck-alt-delete! I've updated the PR accordingly, let me know if you notice any other issues!
recursethis
pushed a commit
to recursethis/materialize-datagen
that referenced
this pull request
Feb 26, 2024
* Add webhook destniation * Add retries in case of 429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adding webhook as a destination.
Currently, this works with basic authentication.
Related Tickets & Documents
N/A
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?