Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsers to json #21

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Parsers to json #21

merged 2 commits into from
Feb 22, 2023

Conversation

bobbyiliev
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

This PR does mainly two things:

  • Removes the --schema-format flag, it now detects the format based on the schema file extension, eg. .sql, .json, .avcs
  • Updates the schema parsers so that each parser produces a JSON schema which is then passed to the Kafka producer

Related Tickets & Documents

Ground work for the #1 issue and #17 PR

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Collaborator

@chuck-alt-delete chuck-alt-delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I’ll approve and incorporate into my other PR and do more testing there

@bobbyiliev bobbyiliev merged commit 320cb4a into main Feb 22, 2023
@bobbyiliev bobbyiliev deleted the parsers-to-json branch February 22, 2023 21:31
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
* Update parsers to generate json schema

* Remove schema format flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants