Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic prefix flag #64

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Add topic prefix flag #64

merged 3 commits into from
Mar 7, 2023

Conversation

bobbyiliev
Copy link
Collaborator

@bobbyiliev bobbyiliev commented Mar 7, 2023

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Taking the time to improve a couple of things:

  • Adding a --prefix|-p flag to allow the usage of topic prefixes in order to avoid name collision.
  • Refactored the code so that we only create 1 Kafka producer and use it across iterations
  • Adding tests for the --clean flag.

Related Tickets & Documents

Closes #61
Closes #54

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@bobbyiliev bobbyiliev merged commit 34f2820 into main Mar 7, 2023
@bobbyiliev bobbyiliev deleted the topic-prefix branch March 7, 2023 14:33
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
* Add topic prefix flag

* Improve Producer Performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add --prefix option to prefix topics and schema subjects Feature: Improve Producer Performance
2 participants