Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker compose example demo #83

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Add docker compose example demo #83

merged 3 commits into from
Mar 17, 2023

Conversation

bobbyiliev
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Adding a docker compose example demo that will allow users to run multiple instances of the datagen simultaneously.

Also moving the e-commerce tutorial to its own directory, that way we would not clutter the examples directory with multiple shared files as we add additional tutorials and demos in there and we will keep it organized.

Related Tickets & Documents

Closes #82

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Collaborator

@chuck-alt-delete chuck-alt-delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we could remove zookeeper? Extra bloat not needed since Kafka went zookeeperless. It’s fine if not

@bobbyiliev
Copy link
Collaborator Author

@chuck-alt-delete sure but do you have a good example of that? I couldn't find a docker image that works out of the box.

The Confluent quick start is still using zookeeper:

https://developer.confluent.io/quickstart/kafka-docker/

@bobbyiliev
Copy link
Collaborator Author

does not seem to work If I try to use the latest confluentinc/cp-kafka image:

dc logs -f kafka
kafka  | ===> User
kafka  | uid=1000(appuser) gid=1000(appuser) groups=1000(appuser)
kafka  | ===> Configuring ...
kafka  | KAFKA_ZOOKEEPER_CONNECT is required.
kafka  | Command [/usr/local/bin/dub ensure KAFKA_ZOOKEEPER_CONNECT] FAILED !

@chuck-alt-delete
Copy link
Collaborator

@bobbyiliev here is a good reference: https://github.com/confluentinc/learn-kafka-kraft

@chuck-alt-delete
Copy link
Collaborator

Here’s an example with a single broker that’s a little more straightforward: https://github.com/confluentinc/cp-all-in-one/blob/7.3.0-post/cp-all-in-one-kraft/docker-compose.yml

@larsenpanda
Copy link

Shameless plug to stand up Redpanda as the Kafka, it's way better in docker.

@bobbyiliev
Copy link
Collaborator Author

Thank you for the suggestion @larsenpanda! Just updated the demo!

@chuck-alt-delete that whole setup seems a bit funky for a simple example, we remove 4 lines of zookeeper definition to add 10+ lines of Kafka configuration and a volume for the update_run.sh script which seems to add more bloat than just starting zookeeper?

@chuck-alt-delete
Copy link
Collaborator

Sounds good!

@bobbyiliev bobbyiliev merged commit 5a970ec into main Mar 17, 2023
@bobbyiliev bobbyiliev deleted the example-docker-compose branch March 17, 2023 16:47
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add docker compose example
3 participants