Show debug output for avro schemas during dry run #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbyiliev
approved these changes
Mar 20, 2023
recursethis
pushed a commit
to recursethis/materialize-datagen
that referenced
this pull request
Feb 26, 2024
…lizeInc#84) * make debug output for avro schemas even during dry run * remove unneeded whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
We lost the ability to see output avro schema when debugging a dry run. This happened because creating an instance of the AvroFormat class requires creating a schema registry client (which shouldn't happen on dry run). However, we don't actually need to create a schema registry client in order to see the what avro schemas would be produced with
--format avro. All that is needed is one instance of a "megaRecord". We then use the @types/avro library to generate avro schema from the record.To bring back this functionality of debugging output avro schema for a dry run, I made the
getAvroSchemas(megaRecord)method static and call it during dry run on the first iteration indataGenerator.Added to documentation?