Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: resolve many lints #88

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Refactor: resolve many lints #88

merged 10 commits into from
Apr 20, 2023

Conversation

sjwiesman
Copy link
Contributor

@sjwiesman sjwiesman commented Mar 23, 2023

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🚩 Other

Description

Fixes many of the lints in npm run lint. This PR is intended to be reviewed one commit at a time.

Related Tickets & Documents

Added to documentation?

  • 📜 readme
  • 🙅 no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

@sjwiesman sjwiesman marked this pull request as ready for review March 23, 2023 15:29
Copy link
Collaborator

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sjwiesman sjwiesman merged commit 4a3e5fd into main Apr 20, 2023
2 checks passed
@sjwiesman sjwiesman deleted the lint branch April 20, 2023 14:40
recursethis pushed a commit to recursethis/materialize-datagen that referenced this pull request Feb 26, 2024
* Refactor: prefer const

* Refactor: Array type using 'Array<T>' is forbidden. Use 'T[]' instead

* Refactor: allow calls to console

* Refactor: triple equals

* Refactor: variable name clashes with keyword/type

* Refactor: non-arrow functions are forbidden

* Refactor: Expected property shorthand in object literal

* Refactor:  Missing radix parameter

* Refactor: shadow name

* Refactor: format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants