coverage: Use exclamation mark to mark uncovered lines

As suggested by Philip
MaterializeInc · Apr 19, 2023 · 142a1cc · 142a1cc
1 parent 2836f89
commit 142a1cc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/doc/developer/assets/coverage-uncovered-lines.png b/doc/developer/assets/coverage-uncovered-lines.png
diff --git a/doc/developer/code-coverage.md b/doc/developer/code-coverage.md
@@ -12,7 +12,7 @@ As an example let's take the *[adapter: Update privileges when an owner is updat
 
 ![Commit: 69de84971e8c16ab459c88be73870bb676dbc478, Branch: jkosh44:update-privilege-owners](assets/coverage-new-build.png)
 
-After some time your [Coverage run](https://buildkite.com/materialize/coverage/builds/26) will be finished and contain a summary of any uncovered lines in the form of a `git diff` where each removed line is not covered:
+After some time your [Coverage run](https://buildkite.com/materialize/coverage/builds/26) will be finished and contain a summary of any uncovered lines in the form of a `git diff` where each line highlighted with a `!` is not covered:
 
 ![Uncovered Lines in Pull Request](assets/coverage-uncovered-lines.png)
 

diff --git a/misc/python/materialize/cli/ci_coverage_pr_report.py b/misc/python/materialize/cli/ci_coverage_pr_report.py
@@ -113,7 +113,9 @@ def get_report(coverage: Coverage) -> str:
                         f.write(line)
                 f.truncate()
 
-        result = subprocess.run(["git", "diff"], check=True, capture_output=True)
+        result = subprocess.run(
+            ["git", "diff", "--output-indicator-old=!"], check=True, capture_output=True
+        )
         return result.stdout.decode("utf-8").strip()
     finally:
         # Restore the code into its original state