Skip to content

Commit

Permalink
Merge pull request #7692 from benesch/warn-everywhere
Browse files Browse the repository at this point in the history
*: reduce all "deny" and "forbid" lints to "warn"
  • Loading branch information
benesch committed Aug 4, 2021
2 parents db12013 + 31af7bd commit 4d2f427
Show file tree
Hide file tree
Showing 22 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion demo/billing/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
//! Further details can be found on the Materialize docs:
//! <https://materialize.com/docs/demos/microservice/>

#![deny(missing_debug_implementations, missing_docs)]
#![warn(missing_debug_implementations, missing_docs)]

use std::process;
use std::sync::Arc;
Expand Down
2 changes: 1 addition & 1 deletion src/aws-util/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Internal AWS utility library for Materialize.

#![deny(missing_docs, missing_debug_implementations)]
#![warn(missing_docs, missing_debug_implementations)]

pub mod aws;
pub mod client;
Expand Down
2 changes: 1 addition & 1 deletion src/ccsr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

//! The `ccsr` crate provides an ergonomic API client for Confluent-compatible
//! schema registries (CCSRs).
Expand Down
2 changes: 1 addition & 1 deletion src/coord/src/session.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Per-connection configuration parameters and state.

#![forbid(missing_docs)]
#![warn(missing_docs)]

use std::collections::HashMap;
use std::mem;
Expand Down
2 changes: 1 addition & 1 deletion src/dataflow/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![forbid(missing_docs)]
#![warn(missing_docs)]

//! Driver for timely/differential dataflow.

Expand Down
2 changes: 1 addition & 1 deletion src/expr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Core expression language.

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

use std::fmt;
use std::ops::Deref;
Expand Down
2 changes: 1 addition & 1 deletion src/expr/src/relation/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![deny(missing_docs)]
#![warn(missing_docs)]

use std::cmp::Ordering;
use std::collections::HashSet;
Expand Down
2 changes: 1 addition & 1 deletion src/http-proxy/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#![deny(missing_docs)]
#![warn(missing_docs)]
#![cfg_attr(nightly_doc_features, feature(doc_cfg))]

//! [<img src="https://materialize.com/wp-content/uploads/2020/01/materialize_logo_primary.png" width=180 align=right>](https://materialize.com)
Expand Down
2 changes: 1 addition & 1 deletion src/interchange/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Translations for various data serialization formats.

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

pub mod avro;
pub mod encode;
Expand Down
2 changes: 1 addition & 1 deletion src/kafka-util/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![deny(missing_docs)]
#![warn(missing_docs)]

//! Utilities for working with Kafka.

Expand Down
2 changes: 1 addition & 1 deletion src/metabase/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
//!
//! [Metabase]: https://metabase.com

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

use std::fmt;
use std::time::Duration;
Expand Down
2 changes: 1 addition & 1 deletion src/ore/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
//! Modules are included in this crate when they are broadly useful but too
//! small to warrant their own crate.

#![deny(missing_docs, missing_debug_implementations)]
#![warn(missing_docs, missing_debug_implementations)]

#[cfg(feature = "test")]
pub mod assert;
Expand Down
4 changes: 2 additions & 2 deletions src/pgrepr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
//! `Value`s are easily converted to and from [`repr::Datum`]s. See, for
//! example, the [`values_from_row`] function.

#![deny(clippy::as_conversions)]
#![deny(missing_docs)]
#![warn(clippy::as_conversions)]
#![warn(missing_docs)]

mod format;
mod types;
Expand Down
2 changes: 1 addition & 1 deletion src/pgwire/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
//! * [CockroachDB pgwire implementation](https://github.com/cockroachdb/cockroach/tree/master/pkg/sql/pgwire)
//! * ["Postgres on the wire" PGCon talk](https://www.pgcon.org/2014/schedule/attachments/330_postgres-for-the-wire.pdf)

#![deny(clippy::as_conversions)]
#![warn(clippy::as_conversions)]

mod codec;
mod message;
Expand Down
2 changes: 1 addition & 1 deletion src/protoc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![forbid(missing_docs)]
#![warn(missing_docs)]

//! A pure Rust protobuf compiler.
//!
Expand Down
2 changes: 1 addition & 1 deletion src/repr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
//! * [`RelationDesc`] describes what it takes to extend a `Row` vertically, and
//! corresponds most closely to what is returned from querying our dataflows

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

mod relation;
mod row;
Expand Down
2 changes: 1 addition & 1 deletion src/sql/src/catalog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

#![forbid(missing_docs)]
#![warn(missing_docs)]

//! Catalog abstraction layer.

Expand Down
2 changes: 1 addition & 1 deletion src/sql/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
//!
//! [`Plan`]: crate::plan::Plan

#![deny(missing_debug_implementations)]
#![warn(missing_debug_implementations)]

macro_rules! unsupported {
($feature:expr) => {
Expand Down
2 changes: 1 addition & 1 deletion src/testdrive/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Integration test driver for Materialize.

#![deny(missing_docs)]
#![warn(missing_docs)]

use std::fs::File;
use std::io::{self, Read};
Expand Down
4 changes: 2 additions & 2 deletions src/transform/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
//! The crate also contains the beginnings of whole-dataflow optimization,
//! which uses the same analyses but spanning multiple dataflow elements.

#![forbid(missing_docs)]
#![deny(missing_debug_implementations)]
#![warn(missing_docs)]
#![warn(missing_debug_implementations)]

use std::collections::HashMap;
use std::error::Error;
Expand Down
2 changes: 1 addition & 1 deletion test/performance/perf-upsert/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

//! Performance test for Materialize Upsert sources

#![deny(missing_debug_implementations, missing_docs)]
#![warn(missing_debug_implementations, missing_docs)]

use std::process;
use std::sync::Arc;
Expand Down
2 changes: 1 addition & 1 deletion test/smith/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
//! Fuzz test Materialize using the Smith fuzzer
//! available at <https://api.jibson.dev/smith>

#![deny(missing_debug_implementations, missing_docs)]
#![warn(missing_debug_implementations, missing_docs)]

use std::process;

Expand Down

0 comments on commit 4d2f427

Please sign in to comment.