More specifically state what is blocking the transform on arbitrary e…

…xpressions.
MaterializeInc · Sep 29, 2020 · a0dd7bd · a0dd7bd
1 parent b72c7bb
commit a0dd7bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/transform/src/join_implementation.rs b/src/transform/src/join_implementation.rs
@@ -81,7 +81,6 @@ impl JoinImplementation {
             ..
         } = relation
         {
-
             // Common information of broad utility.
             // TODO: Figure out how to package this up for everyone who uses it.
             let types = inputs.iter().map(|i| i.typ()).collect::<Vec<_>>();

diff --git a/src/transform/src/use_indexes.rs b/src/transform/src/use_indexes.rs
@@ -93,8 +93,10 @@ impl FilterEqualLiteral {
                         HashMap::new();
                     // gather predicates of the form CallBinary{Binaryfunc::Eq,
                     // Column, Literal}
-                    // TODO (wangandi): materialize#616 relax the requirement
-                    // `Column` to be any arbitrary ScalarExpr
+                    // TODO (wangandi): relax the requirement `Column` to be any
+                    // arbitrary `ScalarExpr`. Currently blocked by
+                    // `ColumnKnowledge` not having been extended to
+                    // `PredicateKnowledge` yet. (See PR #3044)
                     for predicate in predicates.iter() {
                         if let ScalarExpr::CallBinary {
                             func: BinaryFunc::Eq,