Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop TAILs when connection is dropped #2996

Merged
merged 3 commits into from
May 11, 2020
Merged

Drop TAILs when connection is dropped #2996

merged 3 commits into from
May 11, 2020

Conversation

JLDLaughlin
Copy link
Contributor

@JLDLaughlin JLDLaughlin commented May 11, 2020

This change is Reviewable

Copy link
Member

@benesch benesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Sorry for the earlier failed suggestions.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @JLDLaughlin)


src/coord/command.rs, line 55 at r1 (raw file):

    /// Remove temporary objects created by a given connection.
    TerminateConnectionObjects { conn_id: u32 },

Let's just call this Terminate, to be symmetric with Startup!


src/pgwire/protocol.rs, line 111 at r1 (raw file):

    // Clean up state tied to this specific connection.
    cmdq_tx
        .clone()

Unnecessary clone, I'll bet?

@JLDLaughlin JLDLaughlin changed the title WIP: Drop tails when connection is dropped Drop TAILs when connection is dropped May 11, 2020
@JLDLaughlin JLDLaughlin merged commit 60e5789 into MaterializeInc:master May 11, 2020
@JLDLaughlin JLDLaughlin deleted the remove_hanging_tails branch May 11, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants