mzcompose,feature-benchmark: Ensure --dev option is in effect when ne… #10527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eded In order to avoid user frustration, the feature benchmark should run even if the environment has not been primed with bin/pyactivate --dev in advance. * Enable --dev if ./mzcompose from the feature directory is called * Enable --dev if bin/mzcompose --dev is used * Remove the documentation step where bin/pyactivate --dev was mentioned
benesch
added a commit
to benesch/materialize
that referenced
this pull request
Feb 14, 2022
It turns out MaterializeInc#10527 broke use of the `--dev` option to `mzcompose` to mean "build in dev mode rather than release mode". Revert that part of the commit. Instead, teach `bin/mzcompose` to always install dev deps when invoked from the root. We don't tell users about `bin/mzcompose`, so they'll continue to get the reduced set of deps when running mzcompose from a directory locally.
2 tasks
29 tasks
wangandi
pushed a commit
to wangandi/materialize
that referenced
this pull request
Apr 11, 2022
It turns out MaterializeInc#10527 broke use of the `--dev` option to `mzcompose` to mean "build in dev mode rather than release mode". Revert that part of the commit. Instead, teach `bin/mzcompose` to always install dev deps when invoked from the root. We don't tell users about `bin/mzcompose`, so they'll continue to get the reduced set of deps when running mzcompose from a directory locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eded
In order to avoid user frustration, the feature benchmark should run even
if the environment has not been primed with bin/pyactivate --dev in advance.
Motivation
The feature benchmark would only run on environments that were primed with bin/pyactivate --dev in advance. If that step was not executed, a cryptic error would occur which would lead to user frustration.