correct kafka error message during purification #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
approved these changes
Feb 11, 2022
During purification we create a Kafka consumer to validate that connection params are correct and that we can reach the Kafka broker. We potentially use this consumer for fetching things like the start offset if specified, but that's not its primary purpose. Today the error message is confusing because it incorrectly references start offset fetching, even in cases where those params have not been specified in CREATE SOURCE. Rewriting the error message to be slightly more generic
elindsey
force-pushed
the
kafkaerrmsg
branch
from
c665304
to
d2f3309
Compare
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During purification we create a Kafka consumer to validate that
connection params are correct and that we can reach the Kafka broker. We
potentially use this consumer for fetching things like the start offset
if specified, but that's not its primary purpose.
Today the error message is confusing because it incorrectly references
start offset fetching, even in cases where those params have not been
specified in CREATE SOURCE.
Rewriting the error message to be slightly more generic
Motivation
Which of the following best describes the motivation behind this PR?
Checklist