sql: use ScalarType rather than mz_pgrepr::Type as param type
#10619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
force-pushed
the
pgrepr-type
branch
3 times, most recently
from
11832dc
to
813c2b8
Compare
The `mz_pgrepr::Type` is a PostgreSQL implementation detail but had leaked into the Materialize-specific `sql` and `coord` crates. Correct that boundary violation. The code to take a `mz_pgrepr::Value` into a `Datum` gets much simpler in the process; the `pgrepr::Type` type is now directly convertible to a `ScalarType` without looking at the datums involved, so we can massively simplify the signature of `Value::into_datum` and entirely remove `pgrepr::null_datum`.
The length of a character value is a property of the type, not the value.
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mz_pgrepr::Typeis a PostgreSQL implementation detail but hadleaked into the Materialize-specific
sqlandcoordcrates. Correctthat boundary violation. The code to take a
mz_pgrepr::Valueinto aDatumgets much simpler in the process; thepgrepr::Typetype is nowdirectly convertible to a
ScalarTypewithout looking at the datumsinvolved, so we can massively simplify the signature of
Value::into_datumand entirely removepgrepr::null_datum.Motivation
Checklist