repr: make interval output conform to postgres #1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous output style was Postgres-like, but not exactly what Postgres would output. Also fix a bug where nanoseconds were not being output correctly; outputting an integer on the right side of a decimal point requires some care.
|
@sploiselle this is a commit I've had sitting around for a while. I'm worried it might conflict with the interval work you're doing so figured I'd throw it up. |
|
@benesch I have this function (and its tests) totally Postgres-ified in my fork, so not a big deal to either merge this and I can rebase atop it, or wait a couple of days for my PR. nbd. |
|
One thing I'd like to see in this is some tests that demonstrate the ways in which subsecond printing was incorrect. |
|
(I can see that this is correct, but would love tests to make sure that we don't mess up in the future.) |
|
Superseded by #1444! Thanks, @sploiselle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous output style was Postgres-like, but not exactly what
Postgres would output. Also fix a bug where nanoseconds were not being
output correctly; outputting an integer on the right side of a decimal
point requires some care.